Skip to content

Separate progress 3#286

Closed
mudiagaobrikisil wants to merge 1 commit intomasterfrom
separate-progress-3
Closed

Separate progress 3#286
mudiagaobrikisil wants to merge 1 commit intomasterfrom
separate-progress-3

Conversation

@mudiagaobrikisil
Copy link
Copy Markdown
Contributor

@mudiagaobrikisil mudiagaobrikisil commented Feb 20, 2025

Made changes to the Progress Status needed to separate the progress into fineTuneProgress and inferenceProgress


This change is Reviewable

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 70.50%. Comparing base (58098ed) to head (bd4fe6d).

Files with missing lines Patch % Lines
src/SIL.Machine/Utils/ProgressStatus.cs 21.05% 14 Missing and 1 partial ⚠️
src/SIL.Machine/Utils/PhasedProgressReporter.cs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   70.52%   70.50%   -0.02%     
==========================================
  Files         386      386              
  Lines       32299    32313      +14     
  Branches     4543     4546       +3     
==========================================
+ Hits        22779    22783       +4     
- Misses       8472     8482      +10     
  Partials     1048     1048              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnml1135
Copy link
Copy Markdown
Collaborator

-- commits line 9 at r1:
Please rebase instead of merging. It makes the review much harder becaus it mixes the updates to main and the relevant updates. I will continue the review when it is rebased.

@Enkidu93
Copy link
Copy Markdown
Collaborator

-- commits line 9 at r1: Please rebase instead of merging. It makes the review much harder becaus it mixes the updates to main and the relevant updates. I will continue the review when it is rebased.

@mudiagaobrikisil, are you waiting on the deuterocanon PR to go through to rebase? Or why has this stalled?

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 32 files reviewed, 1 unresolved discussion (waiting on @Enkidu93, @johnml1135, and @mudiagaobrikisil)


-- commits line 9 at r1:

Previously, Enkidu93 (Eli C. Lowry) wrote…

@mudiagaobrikisil, are you waiting on the deuterocanon PR to go through to rebase? Or why has this stalled?

One of us will need to take over this PR.

@Enkidu93 Enkidu93 force-pushed the separate-progress-3 branch from 62d3d58 to 45847ec Compare April 29, 2025 21:34
@Enkidu93
Copy link
Copy Markdown
Collaborator

Addresses sillsdev/serval#477

@Enkidu93 Enkidu93 force-pushed the separate-progress-3 branch from 45847ec to bd4fe6d Compare April 29, 2025 21:54
@Enkidu93
Copy link
Copy Markdown
Collaborator

OK, I rebased this. I thought we were planning on using step and total steps not a single double to communicate progress.

@Enkidu93
Copy link
Copy Markdown
Collaborator

I think our strategy might ultimately differ from the one coded in this PR. Also, the issue itself might be pushed back/might be lower priority. For those reasons, I'm going to close this.

@Enkidu93 Enkidu93 closed this Apr 30, 2025
@Enkidu93 Enkidu93 deleted the separate-progress-3 branch April 30, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants